ASF GitHub Bot commented on FLINK-8538:

Github user fhueske commented on a diff in the pull request:

    --- Diff: 
    @@ -128,6 +165,13 @@ class DescriptorProperties(normalizeKeys: Boolean = 
true) {
    +  /**
    +    * Adds a table schema under the given key. This method is intended for 
Java code.
    +    */
    +  def putTableSchema(key: String, nameAndType: JList[JTuple2[String, 
String]]): Unit = {
    --- End diff --
    I think we should drop the Scala equivalent method. This is not a public 
API class that needs a shiny Scala interface but should be usable from Java and 

> Add a Kafka table source factory with JSON format support
> ---------------------------------------------------------
>                 Key: FLINK-8538
>                 URL: https://issues.apache.org/jira/browse/FLINK-8538
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Xingcan Cui
>            Priority: Major
> Similar to CSVTableSourceFactory a Kafka table source factory for JSON should 
> be added. This issue includes improving the existing JSON descriptor with 
> validation that can be used for other connectors as well. It is up for 
> discussion if we want to split the KafkaJsonTableSource into connector and 
> format such that we can reuse the format for other table sources as well.

This message was sent by Atlassian JIRA

Reply via email to