[GitHub] flink pull request #5560: [FLINK-8746] [flip6] Rescale partially running job...

[GJL]

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5560#discussion_r170281192
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
 ---
    @@ -289,7 +290,7 @@ public void invoke() throws Exception {
     
                        // wait forever (until canceled)
                        synchronized (this) {
    -                           while (error == null && lastCheckpointId < 
numCalls) {
    --- End diff --
    
    Are you sure this needed to be removed?


---