[
https://issues.apache.org/jira/browse/FLINK-8773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375592#comment-16375592
]
ASF GitHub Bot commented on FLINK-8773:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5575
[FLINK-8773] [flip6] Make JobManagerRunner shut down non blocking
## What is the purpose of the change
The Dispatcher no longer shuts down the JobManagerRunner in a blocking
fashion.
Instead it registers the termination futures and calls the shut down of the
JobManagerSharedServices once all JobManagerRunners have terminated.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink nonBlockingJobManagerRunner
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5575.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5575
----
commit 4a0735b1a9c60658b00b6e63bfef94e655260f13
Author: Till Rohrmann <trohrmann@...>
Date: 2018-02-24T14:39:31Z
[FLINK-8773] [flip6] Make JobManagerRunner shut down non blocking
The Dispatcher no longer shuts down the JobManagerRunner in a blocking
fashion.
Instead it registers the termination futures and calls the shut down of the
JobManagerSharedServices once all JobManagerRunners have terminated.
----
> Make shut down of JobManagerRunner non blocking
> -----------------------------------------------
>
> Key: FLINK-8773
> URL: https://issues.apache.org/jira/browse/FLINK-8773
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Major
> Labels: flip-6
> Fix For: 1.5.0
>
>
> For a better shut down behaviour, the {{JobManagerRunner}} should be shut
> down in a non blocking fashion.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
