Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5577#discussion_r170526240
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/leaderretrieval/SettableLeaderRetrievalService.java
---
@@ -16,36 +16,34 @@
* limitations under the License.
*/
-package org.apache.flink.runtime.leaderelection;
+package org.apache.flink.runtime.leaderretrieval;
-import org.apache.flink.runtime.leaderretrieval.LeaderRetrievalListener;
-import org.apache.flink.runtime.leaderretrieval.LeaderRetrievalService;
import org.apache.flink.util.Preconditions;
import java.util.UUID;
/**
- * Test {@link LeaderRetrievalService} implementation which directly
forwards calls of
+ * {@link LeaderRetrievalService} implementation which directly forwards
calls of
* notifyListener to the listener.
*/
-public class TestingLeaderRetrievalService implements
LeaderRetrievalService {
+public class SettableLeaderRetrievalService implements
LeaderRetrievalService {
- private volatile String leaderAddress;
- private volatile UUID leaderSessionID;
+ private String leaderAddress;
+ private UUID leaderSessionID;
- private volatile LeaderRetrievalListener listener;
+ private LeaderRetrievalListener listener;
- public TestingLeaderRetrievalService() {
+ public SettableLeaderRetrievalService() {
this(null, null);
}
- public TestingLeaderRetrievalService(String leaderAddress, UUID
leaderSessionID) {
+ public SettableLeaderRetrievalService(String leaderAddress, UUID
leaderSessionID) {
--- End diff --
`Nullable` annotations are missing
---
