[
https://issues.apache.org/jira/browse/FLINK-8756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376687#comment-16376687
]
ASF GitHub Bot commented on FLINK-8756:
---------------------------------------
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5573
OK, base of @aljoscha 's opinion, I describe the implementation detail
before coding :
* define a `AccumulatorRepresentationsQueryParameter` class which extends
`MessageQueryParameter` and contains to two representation mode
(***stringified*** and ***serialized***)
* define a `JobAccumulatorsMessageParameters` class which extends
`MessageParameters`, and the `getQueryParameters` method will return the
`AccumulatorRepresentationsQueryParameter`
* refactor `JobAccumulatorsHeaders#getUnresolvedMessageParameters` return
`JobAccumulatorsMessageParameters`'s instance
* refactor `JobAccumulatorsHandler#handleRequest` it will query specific
accumulator's representation base of
`AccumulatorRepresentationsQueryParameter`, and the `JobAccumulatorsInfo` will
be reused for both representations
* in `RestClusterClient` class , let `getAccumulators` return stringified
accumulators(`Map<String, Object>`) and `getSerializedAccumulators` return
serialized accumulators(`Map<String, SerializedValue<Object>>`)
@tillrohrmann and @GJL hope for your opinions, Thanks.
> Support ClusterClient.getAccumulators() in RestClusterClient
> ------------------------------------------------------------
>
> Key: FLINK-8756
> URL: https://issues.apache.org/jira/browse/FLINK-8756
> Project: Flink
> Issue Type: Improvement
> Components: Client
> Affects Versions: 1.5.0
> Reporter: Aljoscha Krettek
> Assignee: vinoyang
> Priority: Blocker
> Fix For: 1.5.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
