[
https://issues.apache.org/jira/browse/FLINK-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376768#comment-16376768
]
ASF GitHub Bot commented on FLINK-8778:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5579#discussion_r170573280
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java
---
@@ -1307,24 +1268,13 @@ JobID getJobId() {
public void close() throws Exception {
// Free cluster resources
if (jobId != null) {
- cluster.getLeaderGateway(deadline.timeLeft())
- .ask(new
JobManagerMessages.CancelJob(jobId), deadline.timeLeft())
-
.mapTo(ClassTag$.MODULE$.<CancellationSuccess>apply(CancellationSuccess.class));
-
-
cancellationFuture.get(deadline.timeLeft().toMillis(), TimeUnit.MILLISECONDS);
+ clusterClient.cancel(jobId);
+ // cancel() is non-blocking so do this to make
sure the job finished
+ clusterClient.requestJobResult(jobId).get();
--- End diff --
add timeout. We should also check the returned status to make sure it is
actually finished.
> Migrate queryable state ITCases to use MiniClusterResource
> ----------------------------------------------------------
>
> Key: FLINK-8778
> URL: https://issues.apache.org/jira/browse/FLINK-8778
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
> Priority: Blocker
> Fix For: 1.5.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
