[ 
https://issues.apache.org/jira/browse/FLINK-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378328#comment-16378328
 ] 

ASF GitHub Bot commented on FLINK-8778:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5579#discussion_r170863015
  
    --- Diff: 
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java
 ---
    @@ -188,12 +179,12 @@ public Integer getKey(Tuple2<Integer, Long> value) {
                        }
                }).asQueryableState(queryName, reducingState);
     
    -           try (AutoCancellableJob autoCancellableJob = new 
AutoCancellableJob(cluster, env, deadline)) {
    +           try (AutoCancellableJob autoCancellableJob = new 
AutoCancellableJob(clusterClient, env)) {
     
                        final JobID jobId = autoCancellableJob.getJobId();
                        final JobGraph jobGraph = 
autoCancellableJob.getJobGraph();
     
    -                   cluster.submitJobDetached(jobGraph);
    +                   clusterClient.submitJob(jobGraph, 
AbstractQueryableStateTestBase.class.getClassLoader());
    --- End diff --
    
    How is this change equivalent? This could easily be a blocking job 
submission.


> Migrate queryable state ITCases to use MiniClusterResource
> ----------------------------------------------------------
>
>                 Key: FLINK-8778
>                 URL: https://issues.apache.org/jira/browse/FLINK-8778
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Tests
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Blocker
>             Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to