[
https://issues.apache.org/jira/browse/FLINK-8768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378528#comment-16378528
]
ASF GitHub Bot commented on FLINK-8768:
---------------------------------------
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5570#discussion_r170911555
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyMessageSerializationTest.java
---
@@ -44,10 +44,11 @@
*/
public class NettyMessageSerializationTest {
+ public static final boolean RESTORE_OLD_NETTY_BEHAVIOUR = false;
--- End diff --
dead code ;)
> Change NettyMessageDecoder to inherit from LengthFieldBasedFrameDecoder
> -----------------------------------------------------------------------
>
> Key: FLINK-8768
> URL: https://issues.apache.org/jira/browse/FLINK-8768
> Project: Flink
> Issue Type: Improvement
> Components: Network
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Priority: Major
> Fix For: 1.5.0
>
>
> Let {{NettyMessageDecoder}} inherit from {{LengthFieldBasedFrameDecoder}}
> instead of being an additional step in the pipeline. This does not only
> remove overhead in the pipeline itself but also allows use to override the
> {{#extractFrame()}} method to restore the old Netty 4.0.27 behaviour for
> non-credit based code paths which had a bug with Netty >= 4.0.28 there.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
