[ https://issues.apache.org/jira/browse/FLINK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378597#comment-16378597 ]
ASF GitHub Bot commented on FLINK-8737: --------------------------------------- Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5583#discussion_r170923061 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/UnionInputGate.java --- @@ -189,11 +189,11 @@ public void requestPartitions() throws IOException, InterruptedException { bufferOrEvent.setChannelIndex(channelIndexOffset + bufferOrEvent.getChannelIndex()); - return Optional.ofNullable(bufferOrEvent); + return Optional.of(bufferOrEvent); } @Override - public Optional<BufferOrEvent> pollNextBufferOrEvent() throws IOException, InterruptedException { + public Optional<BufferOrEvent> pollNextBufferOrEvent() throws UnsupportedOperationException { --- End diff -- Do you need to declare to throw this exception? Do we want to declare `RuntimeExceptions`? > Creating a union of UnionGate instances will fail with > UnsupportedOperationException when retrieving buffers > ------------------------------------------------------------------------------------------------------------ > > Key: FLINK-8737 > URL: https://issues.apache.org/jira/browse/FLINK-8737 > Project: Flink > Issue Type: Sub-task > Components: Network > Reporter: Nico Kruber > Assignee: Nico Kruber > Priority: Blocker > Fix For: 1.5.0 > > > FLINK-8589 introduced a new polling method but did not implement > {{UnionInputGate#pollNextBufferOrEvent()}}. This prevents UnionGate instances > from containing a UnionGate instance which is explicitly allowed by its > documentation and interface. -- This message was sent by Atlassian JIRA (v7.6.3#76005)