[
https://issues.apache.org/jira/browse/FLINK-8428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378649#comment-16378649
]
ASF GitHub Bot commented on FLINK-8428:
---------------------------------------
Github user hequn8128 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5327#discussion_r170936524
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/UpdatingPlanChecker.scala
---
@@ -149,45 +148,39 @@ object UpdatingPlanChecker {
}
case j: DataStreamJoin =>
- val joinType = j.getJoinType
- joinType match {
- case JoinRelType.INNER =>
- // get key(s) for inner join
- val lInKeys = visit(j.getLeft)
- val rInKeys = visit(j.getRight)
- if (lInKeys.isEmpty || rInKeys.isEmpty) {
- None
- } else {
- // Output of inner join must have keys if left and right
both contain key(s).
- // Key groups from both side will be merged by join
equi-predicates
- val lInNames: Seq[String] =
j.getLeft.getRowType.getFieldNames
- val rInNames: Seq[String] =
j.getRight.getRowType.getFieldNames
- val joinNames = j.getRowType.getFieldNames
-
- // if right field names equal to left field names, calcite
will rename right
- // field names. For example, T1(pk, a) join T2(pk, b),
calcite will rename T2(pk, b)
- // to T2(pk0, b).
- val rInNamesToJoinNamesMap = rInNames
- .zip(joinNames.subList(lInNames.size, joinNames.length))
- .toMap
+ // get key(s) for inner join
+ val lInKeys = visit(j.getLeft)
+ val rInKeys = visit(j.getRight)
+ if (lInKeys.isEmpty || rInKeys.isEmpty) {
+ None
+ } else {
+ // Output of inner join must have keys if left and right both
contain key(s).
--- End diff --
Yes, thank you
> Implement stream-stream non-window left outer join
> --------------------------------------------------
>
> Key: FLINK-8428
> URL: https://issues.apache.org/jira/browse/FLINK-8428
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Hequn Cheng
> Assignee: Hequn Cheng
> Priority: Major
>
> Implement stream-stream non-window left outer join for sql/table-api. A
> simple design doc can be found
> [here|https://docs.google.com/document/d/1u7bJHeEBP_hFhi8Jm4oT3FqQDOm2pJDqCtq1U1WMHDo/edit?usp=sharing]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
