Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5578#discussion_r171177186
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskLocalStateStoreImpl.java
 ---
    @@ -300,6 +291,32 @@ private void deleteDirectory(File directory) throws 
IOException {
                }
        }
     
    +   /**
    +    * Pruning the useless checkpoints.
    +    */
    +   private void pruneCheckpoints(long checkpointID, boolean 
breakTheIteration) {
    +
    +           Iterator<Map.Entry<Long, TaskStateSnapshot>> entryIterator =
    +                   storedTaskStateByCheckpointID.entrySet().iterator();
    +
    +           final List<Map.Entry<Long, TaskStateSnapshot>> toRemove = new 
ArrayList<>();
    +
    +           while (entryIterator.hasNext()) {
    +
    +                   Map.Entry<Long, TaskStateSnapshot> snapshotEntry = 
entryIterator.next();
    +                   long entryCheckpointId = snapshotEntry.getKey();
    +
    +                   if (entryCheckpointId != checkpointID) {
    --- End diff --
    
    That is fine, from my point of view that is just one way of making the `if` 
more complex.


---

Reply via email to