Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/5594#discussion_r171196255
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/AbstractHandler.java
---
@@ -84,8 +84,8 @@ protected AbstractHandler(
@Override
protected void respondAsLeader(ChannelHandlerContext ctx, Routed
routed, T gateway) throws Exception {
- if (log.isDebugEnabled()) {
- log.debug("Received request " +
routed.request().getUri() + '.');
+ if (log.isTraceEnabled()) {
--- End diff --
Does `routed.request().getUri()` perform some decoding work? If not, why
not simply use
```java
log.trace("Received request {}.", routed.request().getUri());
```
which should be very efficient (no object creation, string concatenation,
etc). Results even in less byte code.
---
