[
https://issues.apache.org/jira/browse/FLINK-8800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380091#comment-16380091
]
ASF GitHub Bot commented on FLINK-8800:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/5594#discussion_r171196255
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/AbstractHandler.java
---
@@ -84,8 +84,8 @@ protected AbstractHandler(
@Override
protected void respondAsLeader(ChannelHandlerContext ctx, Routed
routed, T gateway) throws Exception {
- if (log.isDebugEnabled()) {
- log.debug("Received request " +
routed.request().getUri() + '.');
+ if (log.isTraceEnabled()) {
--- End diff --
Does `routed.request().getUri()` perform some decoding work? If not, why
not simply use
```java
log.trace("Received request {}.", routed.request().getUri());
```
which should be very efficient (no object creation, string concatenation,
etc). Results even in less byte code.
> Set Logging to TRACE for
> org.apache.flink.runtime.rest.handler.job.metrics.JobVertexMetricsHandler
> --------------------------------------------------------------------------------------------------
>
> Key: FLINK-8800
> URL: https://issues.apache.org/jira/browse/FLINK-8800
> Project: Flink
> Issue Type: Bug
> Components: REST
> Reporter: Stephan Ewen
> Assignee: Chesnay Schepler
> Priority: Blocker
> Fix For: 1.5.0, 1.6.0
>
>
> When setting the log level to {{DEBUG}}, the logs are swamped with statements
> as below, making it hard to read the debug logs.
> {code}
> 2018-02-22 13:41:04,016 DEBUG
> org.apache.flink.runtime.rest.handler.job.metrics.JobVertexMetricsHandler -
> Received request
> /jobs/ec1c9d7a3c413a9523656efa58735009/vertices/ded95c643b42f31cf882a8986207fd30/metrics?get=0.currentLowWatermark.
> 2018-02-22 13:41:04,048 DEBUG
> org.apache.flink.runtime.rest.handler.job.metrics.JobVertexMetricsHandler -
> Received request
> /jobs/ec1c9d7a3c413a9523656efa58735009/vertices/eec5890dac9c38f66954443809beb5b0/metrics?get=0.currentLowWatermark.
> 2018-02-22 13:41:04,052 DEBUG
> org.apache.flink.runtime.rest.handler.job.metrics.JobVertexMetricsHandler -
> Received request
> /jobs/ec1c9d7a3c413a9523656efa58735009/vertices/2a964ee72788c82cb7d15e352d9a94f6/metrics?get=0.currentLowWatermark.
> 2018-02-22 13:41:04,079 DEBUG
> org.apache.flink.runtime.rest.handler.job.metrics.JobVertexMetricsHandler -
> Received request
> /jobs/ec1c9d7a3c413a9523656efa58735009/vertices/1d9c83f6e1879fdbe461aafac16eb8a5/metrics?get=0.currentLowWatermark.
> 2018-02-22 13:41:04,085 DEBUG
> org.apache.flink.runtime.rest.handler.job.metrics.JobVertexMetricsHandler -
> Received request
> /jobs/ec1c9d7a3c413a9523656efa58735009/vertices/4063620891a151092c5bcedb218870a6/metrics?get=0.currentLowWatermark.
> 2018-02-22 13:41:04,094 DEBUG
> org.apache.flink.runtime.rest.handler.job.metrics.JobVertexMetricsHandler -
> Received request
> /jobs/ec1c9d7a3c413a9523656efa58735009/vertices/2a751c66e0e32aee2cd8120a1a72a4d6/metrics?get=0.currentLowWatermark.
> 2018-02-22 13:41:04,142 DEBUG
> org.apache.flink.runtime.rest.handler.job.metrics.JobVertexMetricsHandler -
> Received request
> /jobs/ec1c9d7a3c413a9523656efa58735009/vertices/37ecc85b429bd08d0fd539532055e117/metrics?get=0.currentLowWatermark.
> 2018-02-22 13:41:04,173 DEBUG
> org.apache.flink.runtime.rest.handler.job.metrics.JobVertexMetricsHandler -
> Received request
> /jobs/ec1c9d7a3c413a9523656efa58735009/vertices/20e20298680571979f690d36d1a6db36/metrics?get=0.currentLowWatermark.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
