[ 
https://issues.apache.org/jira/browse/FLINK-8792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380211#comment-16380211
 ] 

ASF GitHub Bot commented on FLINK-8792:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5587


>  bad semantic of method name MessageQueryParameter.convertStringToValue 
> ------------------------------------------------------------------------
>
>                 Key: FLINK-8792
>                 URL: https://issues.apache.org/jira/browse/FLINK-8792
>             Project: Flink
>          Issue Type: Improvement
>          Components: REST
>            Reporter: vinoyang
>            Assignee: vinoyang
>            Priority: Minor
>             Fix For: 1.5.0, 1.6.0
>
>
> the method name
> {code:java}
> MessageQueryParameter.convertStringToValue
> {code}
> should be 
> {code:java}
> convertValueToString
> {code}
> or
> {code:java}
> convertStringFromValue{code}
>  I think 
> {code:java}
> convertValueToString
> {code}
> would be better.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to