[
https://issues.apache.org/jira/browse/FLINK-8557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380304#comment-16380304
]
ASF GitHub Bot commented on FLINK-8557:
---------------------------------------
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/5598
[FLINK-8557][checkpointing] Remove illegal characters from operator d…
## What is the purpose of the change
This fixes the problem that the operator descriptor text is used to
construct the instance directory in RocksDB, but can contain characters that
are illegal for paths in some file systems.
## Brief change log
We replace all illegal characters with underscore before constructing the
path.
## Verifying this change
Check if RocksDB can be used as state backend on Windows.
This change is a trivial rework / code cleanup without any test coverage.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StefanRRichter/flink
FLINK-8557-descriptor-text
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5598.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5598
----
commit 66474dac7ed401264d2ec5ccac3abcb5ec4999d0
Author: Stefan Richter <s.richter@...>
Date: 2018-02-28T13:25:55Z
[FLINK-8557][checkpointing] Remove illegal characters from operator
description text before using it to construct the instance directory in RocksDB
----
> OperatorSubtaskDescriptionText causes failures on Windows
> ---------------------------------------------------------
>
> Key: FLINK-8557
> URL: https://issues.apache.org/jira/browse/FLINK-8557
> Project: Flink
> Issue Type: Bug
> Components: State Backends, Checkpointing, Streaming, Tests
> Affects Versions: 1.5.0
> Reporter: Chesnay Schepler
> Assignee: Stefan Richter
> Priority: Blocker
>
> File-based state backends that use the description provided by
> {{OperatorSubtaskDescriptionText}} for file names will categorically fail on
> Windows as they contain characters that aren't allowed in paths "(", ")" and
> "/".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
