[
https://issues.apache.org/jira/browse/FLINK-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381420#comment-16381420
]
ASF GitHub Bot commented on FLINK-8816:
---------------------------------------
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/5604
[FLINK-8816][ResourceManager] Remove the oldWorker only after starting
newWorker successfully
## What is the purpose of the change
This PR address
[FLINK-8816](https://issues.apache.org/jira/browse/FLINK-8816), We should
remove the oldWorker only after starting newWorker successfully in
`ResourceManager#registerTaskExecutorInternal` and javadoc for
`SlotProvider#allocateSlot` is outdated.
## Brief change log
- Fix bug `registerTaskExecutorInternal()`, remove old worker after
starting newWorker successfully.
- Fix javadoc for SlotProvider#allocateSlot.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
- The S3 file system connector: (no)
## Documentation
no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sihuazhou/flink
fix_registerTaskExecutorInternal_bug_and_javadoc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5604.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5604
----
commit 98e93adf7f006f09b9ff801d67ac801563ad9973
Author: sihuazhou <summerleafs@...>
Date: 2018-03-01T02:24:53Z
1. Fix bug `registerTaskExecutorInternal()`, remove old worker after
starting the newWorker successfully.
2. Fix javadoc for SlotProvider#allocateSlot.
----
> Remove the oldWorker only after starting newWorker successfully in
> registerTaskExecutorInternal()
> -------------------------------------------------------------------------------------------------
>
> Key: FLINK-8816
> URL: https://issues.apache.org/jira/browse/FLINK-8816
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Sihua Zhou
> Assignee: Sihua Zhou
> Priority: Major
> Fix For: 1.5.0
>
>
> We should remove the oldWorker only after starting newWorker successfully in
> {{ResourceManager#registerTaskExecutorInternal}} and javadoc for
> {{SlotProvider#allocateSlot}} is outdated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
