[
https://issues.apache.org/jira/browse/FLINK-8817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381583#comment-16381583
]
ASF GitHub Bot commented on FLINK-8817:
---------------------------------------
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/5605
[FLINK-8817][Distributed Coordination] Decrement
numPendingContainerRequests only when request container successfully
## What is the purpose of the change
This PR address
[FLINK-8817](https://issues.apache.org/jira/browse/FLINK-8817), We should
decrement numPendingContainerRequests only when request container successfully.
Otherwise, the re-requested container can be released.
## Brief change log
- Decrement numPendingContainerRequests only when request container
successfully
## Verifying this change
This change is a trivial rework without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
- The S3 file system connector: (no)
## Documentation
no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sihuazhou/flink
fix_decremnt_numPendingContainerRequests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5605.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5605
----
commit 7f4bcfe5a74d69c9a6f68aab1621646cb73e8a0e
Author: sihuazhou <summerleafs@...>
Date: 2018-03-01T06:33:51Z
Decrement numPendingContainerRequests only when request container
successfully.
----
> Decrement numPendingContainerRequests only when request container successfully
> ------------------------------------------------------------------------------
>
> Key: FLINK-8817
> URL: https://issues.apache.org/jira/browse/FLINK-8817
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Sihua Zhou
> Assignee: Sihua Zhou
> Priority: Major
> Fix For: 1.5.0
>
>
> We should decrement {{numPendingContainerRequests}} only when request
> container successfully. Otherwise, the re-requested container can be released.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
