[
https://issues.apache.org/jira/browse/FLINK-8822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381835#comment-16381835
]
ASF GitHub Bot commented on FLINK-8822:
---------------------------------------
GitHub user BigOneLiu opened a pull request:
https://github.com/apache/flink/pull/5609
[FLINK-8822] RotateLogFile may not work well when sed version is belo…
…w 4.2
In bin/config.sh rotateLogFilesWithPrefix(),it use extended regular to
process filename with "sed -E",but when sed version is below 4.2,it turns out
"sed: invalid option – 'E'"
and RotateLogFile won't work well : There will be only one logfile no
matter what is $MAX_LOG_FILE_NUMBER.
so use sed -r may be more suitable.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BigOneLiu/flink master0228
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5609.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5609
----
commit c8a008699bc7ae13310c1069665891d18e800c7c
Author: liuxin <liu.xin18@...>
Date: 2018-03-01T10:59:28Z
[FLINK-8822] RotateLogFile may not work well when sed version is below 4.2
----
> RotateLogFile may not work well when sed version is below 4.2
> -------------------------------------------------------------
>
> Key: FLINK-8822
> URL: https://issues.apache.org/jira/browse/FLINK-8822
> Project: Flink
> Issue Type: Bug
> Affects Versions: 1.4.0
> Reporter: Xin Liu
> Priority: Major
> Fix For: 1.5.0
>
>
> In bin/config.sh rotateLogFilesWithPrefix(),it use extended regular to
> process filename with "sed -E",but when sed version is below 4.2,it turns out
> "sed: invalid option -- 'E'"
> and RotateLogFile won't work well : There will be only one logfile no matter
> what is $MAX_LOG_FILE_NUMBER.
> so use sed -r may be more suitable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
