[GitHub] flink pull request #5317: [FLINK-8458] Add the switch for keeping both the o...

[pnowojski]

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5317#discussion_r166921740
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/SequenceNumberingViewReader.java
 ---
    @@ -77,14 +78,35 @@ void requestSubpartitionView(
                }
        }
     
    -   InputChannelID getReceiverId() {
    +   @Override
    +   public void addCredit(int creditDeltas) {
    +   }
    +
    +   @Override
    +   public void setRegisteredAsAvailable(boolean isRegisteredAvailable) {
    +   }
    +
    +   @Override
    +   public boolean isRegisteredAsAvailable() {
    +           return false;
    --- End diff --
    
    Why this is not implemented?


---