GitHub user twalthr opened a pull request:

    https://github.com/apache/flink/pull/5613

    [FLINK-8274] [table] Split generated methods for preventing compiler 
exceptions

    ## What is the purpose of the change
    
    This PR splits a result record into multiple methods that evaluate a field. 
This prevents compiler exceptions such as mentioned in FLINK-8274. In 
comparison to #5174 this PR prevents the exception for all generated functions 
and also covers corner cases such as timestamps.
    
    ## Brief change log
    
    - Splitting added to code generation classes
    
    ## Verifying this change
    
    See added unit tests.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): yes
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? JavaDocs


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-8274_3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5613.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5613
    
----
commit 5e967692887b403a7d86805b21956773ed9c6f02
Author: Timo Walther <twalthr@...>
Date:   2018-03-01T15:26:21Z

    [FLINK-8274] [table] Split generated methods for preventing compiler 
exceptions

----


---

Reply via email to