Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5622#discussion_r171858158
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/job/savepoints/SavepointTriggerRequestBodyTest.java
 ---
    @@ -34,8 +34,8 @@
        }
     
        @Override
    -   protected SavepointTriggerRequestBody getTestRequestInstance() throws 
Exception {
    -           return new SavepointTriggerRequestBody("/tmp");
    +   protected SavepointTriggerRequestBody getTestRequestInstance() {
    +           return new SavepointTriggerRequestBody("/tmp", true);
    --- End diff --
    
    strictly speaking the `false` case should be tested as well


---

Reply via email to