[
https://issues.apache.org/jira/browse/FLINK-8402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383822#comment-16383822
]
ASF GitHub Bot commented on FLINK-8402:
---------------------------------------
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/5624
[FLINK-8402][s3][tests] fix hadoop/presto S3 IT cases for
eventually-consistent operations
## What is the purpose of the change
`HadoopS3FileSystemITCase` and `PrestoS3FileSystemITCase` rely on
consistent read-after-write and delete operations which S3 does not offer and
which the `FileSystem` wrappers not always circumvent. Also see
https://docs.aws.amazon.com/AmazonS3/latest/dev/Introduction.html#ConsistencyModel
Please merge into `master` and `release-1.5` after accepting.
## Brief change log
- harden `HadoopS3FileSystemITCase` with respect to eventual-consistent
operations by adding retries of existence checks with an overall deadline of 30s
- harden `PrestoS3FileSystemITCase` with respect to eventual-consistent
operations by adding retries of existence checks with an overall deadline of 30s
## Verifying this change
This change is already covered by existing tests, such as
`HadoopS3FileSystemITCase` and `PrestoS3FileSystemITCase` which occasionally
failed.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
- The S3 file system connector: **yes**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-8402
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5624.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5624
----
commit f916ca6d445b5c47903d03440fdb2dabcf504090
Author: Nico Kruber <nico@...>
Date: 2018-03-02T16:26:48Z
[FLINK-8402][s3][tests] fix hadoop/presto S3 IT cases for
eventually-consistent operations
Also see
https://docs.aws.amazon.com/AmazonS3/latest/dev/Introduction.html#ConsistencyModel
----
> HadoopS3FileSystemITCase.testDirectoryListing fails on Travis
> -------------------------------------------------------------
>
> Key: FLINK-8402
> URL: https://issues.apache.org/jira/browse/FLINK-8402
> Project: Flink
> Issue Type: Bug
> Components: FileSystem, Tests
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Nico Kruber
> Priority: Blocker
> Labels: test-stability
> Fix For: 1.5.0, 1.4.3
>
>
> The test {{HadoopS3FileSystemITCase.testDirectoryListing}} fails on Travis.
> https://travis-ci.org/tillrohrmann/flink/jobs/327021175
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
