Github user zhangminglei commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5449#discussion_r172004016
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/net/ConnectionUtilsTest.java
 ---
    @@ -61,7 +61,7 @@ public void testReturnLocalHostAddressUsingHeuristics() 
throws Exception {
                        assertNotNull(add);
     
                        // make sure that we returned the 
InetAddress.getLocalHost as a heuristic
    -                   assertEquals(InetAddress.getLocalHost(), add);
    +                   assertEquals(InetAddress.getByName("localhost"), add);
    --- End diff --
    
    Thanks @NicoK review. Yes. I think this is a better way to use ```null``` 
instead of ```InetAddress.getLocalHost()``` to prevent multiple adapters cache 
expires from getting a  another result in the future. I will give a quick fix 
for that.


---

Reply via email to