[ 
https://issues.apache.org/jira/browse/FLINK-8818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385943#comment-16385943
 ] 

ASF GitHub Bot commented on FLINK-8818:
---------------------------------------

Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5601#discussion_r172152959
  
    --- Diff: 
flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTest.java ---
    @@ -200,13 +201,23 @@ static void testCopyFromLocalRecursive(
                        while (targetFilesIterator.hasNext()) {
                                LocatedFileStatus targetFile = 
targetFilesIterator.next();
     
    -                           try (FSDataInputStream in = 
targetFileSystem.open(targetFile.getPath())) {
    -                                   String absolutePathString = 
targetFile.getPath().toString();
    -                                   String relativePath = 
absolutePathString.substring(workDirPrefixLength);
    -                                   targetFiles.put(relativePath, 
in.readUTF());
    -
    -                                   assertEquals("extraneous data in file " 
+ relativePath, -1, in.read());
    -                           }
    +                           int retries = 5;
    --- End diff --
    
    I wonder if this should be a magic number or better something that can be 
configured?


> Harden YarnFileStageTest upload test for eventual consistent read-after-write
> -----------------------------------------------------------------------------
>
>                 Key: FLINK-8818
>                 URL: https://issues.apache.org/jira/browse/FLINK-8818
>             Project: Flink
>          Issue Type: Sub-task
>          Components: FileSystem, Tests, YARN
>    Affects Versions: 1.5.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Blocker
>             Fix For: 1.5.0, 1.4.3
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to