[
https://issues.apache.org/jira/browse/FLINK-8839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386152#comment-16386152
]
ASF GitHub Bot commented on FLINK-8839:
---------------------------------------
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/5640
[FLINK-8839] [sql-client] Fix table source factory discovery
## What is the purpose of the change
This PR fixes the table source factory discovery by adding dependencies to
the classloader. It also implements an `ExecutionContext` that can be reused
during the same session.
## Brief change log
- New `ExecutionContext` abstraction
- Possibility to pass a classloader to the Java service provider
## Verifying this change
- See `DependencyTest`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? JavaDocs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink FLINK-8839
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5640.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5640
----
commit 8c7b1427f94082dc023073125b32eceda556d8cd
Author: Timo Walther <twalthr@...>
Date: 2018-03-05T12:46:41Z
[FLINK-8839] [sql-client] Fix table source factory discovery
----
> Table source factory discovery is broken in SQL Client
> ------------------------------------------------------
>
> Key: FLINK-8839
> URL: https://issues.apache.org/jira/browse/FLINK-8839
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Timo Walther
> Priority: Blocker
> Fix For: 1.5.0
>
>
> Table source factories cannot not be discovered if they were added using a
> jar file.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
