[
https://issues.apache.org/jira/browse/FLINK-8687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388919#comment-16388919
]
ASF GitHub Bot commented on FLINK-8687:
---------------------------------------
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/5647
[FLINK-8687] Make MaterializedCollectStreamResult#retrievePage to hav…
…e resultLock
## What is the purpose of the change
Currently ```MaterializedCollectStreamResult#retrievePage``` checks page
range and calls snapshot.subList() without holding resultLock. resultLock
should be taken.
## Brief change log
Add synchronized to protect it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-8687
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5647.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5647
----
commit e3308ba0914404d424dfbc17c70d1b948c97b175
Author: mingleiZhang <zml13856086071@...>
Date: 2018-03-07T02:36:52Z
[FLINK-8687] Make MaterializedCollectStreamResult#retrievePage to have
resultLock
----
> MaterializedCollectStreamResult#retrievePage should take resultLock
> -------------------------------------------------------------------
>
> Key: FLINK-8687
> URL: https://issues.apache.org/jira/browse/FLINK-8687
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: mingleizhang
> Priority: Major
>
> Currently MaterializedCollectStreamResult#retrievePage checks page range and
> calls snapshot.subList() without holding resultLock.
> {{resultLock}} should be taken.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
