ASF GitHub Bot commented on FLINK-8889:

GitHub user zentol opened a pull request:


    [FLINK-8889][tests] Do not override cluster config values

    ## What is the purpose of the change
    This PR modifies the cluster configuration in {{MiniClusterResource}} or 
{{TestBaseUtils}} to not categorically override several options. They are now 
only set if they weren't previously configured (i.e. by the test itself). 
    ## Verifying this change
    This change is a trivial rework / code cleanup without any test coverage.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 8889

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5651
commit dafff1946e20e6f3884398b705bbeb4f70462efa
Author: zentol <chesnay@...>
Date:   2018-03-07T09:18:03Z

    [FLINK-8889][tests] Do not override cluster config values


> Do not override config values in TestBaseUtils#startCluster
> -----------------------------------------------------------
>                 Key: FLINK-8889
>                 URL: https://issues.apache.org/jira/browse/FLINK-8889
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.5.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>             Fix For: 1.5.0
> {{TestBaseUtils#startCluster}} is a utility method to easily start a cluster. 
> This method receives a Configuration to be used for the cluster, it does 
> however override several values regardless of whether they were set or not.
> It also sets various options to their default value which shouldn't be 
> necessary.

This message was sent by Atlassian JIRA

Reply via email to