Github user zentol commented on a diff in the pull request:
    --- Diff: 
    @@ -290,16 +289,14 @@ public static boolean checkpointsMatch(
                Collection<CompletedCheckpoint> first,
                Collection<CompletedCheckpoint> second) {
    -           Set<Tuple2<Long, JobID>> firstInterestingFields =
    -                   new HashSet<>();
    +           List<Tuple2<Long, JobID>> firstInterestingFields = new 
                for (CompletedCheckpoint checkpoint : first) {
    --- End diff --
    For stability purposes we may want to check whether the input collections 
are actually sorted.. I know that the sole user 
`ZooKeeperCompletedCheckpointStore` does in fact pass sorted lists, but 
technically there's no guarantee at the moment.


Reply via email to