[
https://issues.apache.org/jira/browse/FLINK-8861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16389906#comment-16389906
]
ASF GitHub Bot commented on FLINK-8861:
---------------------------------------
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/5660
[FLINK-8861] [table] Add support for batch queries in SQL Client
## What is the purpose of the change
This PR added support for batch queries in SQL Client.
## Brief change log
- Added a `StaticResult` and a `BatchResult` for the batch query results.
- Added related methods to `ResultStore` for static results and renamed
the existing methods with a prefix "dynamic".
- Added the logic for retrieving batch query results consulting to
`Dataset.collect()`.
- Adapted the viewing logic for static results to a "two-phase" table
result view.
- Added the first-page option to `CliTableResultView.java`.
- Replaced some default values with `""` in `Execution.java`.
## Verifying this change
This change can be verified by the added test case
`testBatchQueryExecution()`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (JavaDocs)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xccui/flink FLINK-8861
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5660.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5660
----
commit 85225d504114fe80b1dc6cd85cb5e3daf1a55d36
Author: Xingcan Cui <xingcanc@...>
Date: 2018-03-07T17:12:55Z
[FLINK-8861][table]Add support for batch queries in SQL Client
----
> Add support for batch queries in SQL Client
> -------------------------------------------
>
> Key: FLINK-8861
> URL: https://issues.apache.org/jira/browse/FLINK-8861
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Xingcan Cui
> Priority: Major
>
> This issue is a subtask of part two "Full Embedded SQL Client" of the
> implementation plan mentioned in
> [FLIP-24|https://cwiki.apache.org/confluence/display/FLINK/FLIP-24+-+SQL+Client].
> Similar to streaming queries, it should be possible to execute batch queries
> in the SQL Client and collect the results using {{DataSet.collect()}} for
> debugging purposes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
