[
https://issues.apache.org/jira/browse/FLINK-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391226#comment-16391226
]
ASF GitHub Bot commented on FLINK-6053:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/5501#discussion_r173148163
--- Diff:
flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/MetricGroup.java
---
@@ -87,9 +89,27 @@
* @param gauge gauge to register
* @param <T> return type of the gauge
* @return the given gauge
+ * @deprecated use {@link #register(String, NumberGauge)} or {@link
#register(String, StringGauge)} instead
*/
+ @Deprecated
<T, G extends Gauge<T>> G gauge(String name, G gauge);
+ /**
+ * Registers a new {@link org.apache.flink.metrics.NumberGauge} with
Flink.
--- End diff --
Minor: You don't need the fully qualified class name, the JavaDocs actually
read easier with just the class names.
> Gauge<T> should only take subclasses of Number, rather than everything
> ----------------------------------------------------------------------
>
> Key: FLINK-6053
> URL: https://issues.apache.org/jira/browse/FLINK-6053
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Affects Versions: 1.2.0
> Reporter: Bowen Li
> Assignee: Chesnay Schepler
> Priority: Major
> Fix For: 1.6.0
>
>
> Currently, Flink's Gauge is defined as
> ```java
> public interface Gauge<T> extends Metric {
> T getValue();
> }
> ```
> But it doesn't make sense to have Gauge take generic types other than Number.
> And it blocks I from finishing FLINK-6013, because I cannot assume Gauge is
> only about Number. So the class should be like
> ```java
> public interface Gauge<T extends Number> extends Metric {
> T getValue();
> }
> ```
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
