ASF GitHub Bot commented on FLINK-8916:

GitHub user yanghua opened a pull request:


    [FLINK-8916] Checkpointing Mode is always shown to be "At Least Once" in 
Web UI

    ## What is the purpose of the change
    *This pull request add a customized serializer for checkpoint processing 
mode to support the Web UI's Presentation. *
    ## Brief change log
      - *Add a customized serializer for checkpoint processing mode*
    ## Verifying this change
    This change is already covered by existing tests*.
    ## Does this pull request potentially affect one of the following parts:
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / 
**no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    ## Documentation
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (not applicable / docs / 
JavaDocs / **not documented**)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yanghua/flink FLINK-8916

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5679
commit ff1370e7727d4c6e58f0ab249dcf58bff076c480
Author: yanghua <yanghua1127@...>
Date:   2018-03-12T04:12:56Z

    [FLINK-8916] Checkpointing Mode is always shown to be "At Least Once" in 
Web UI


> Checkpointing Mode is always shown to be "At Least Once" in Web UI
> ------------------------------------------------------------------
>                 Key: FLINK-8916
>                 URL: https://issues.apache.org/jira/browse/FLINK-8916
>             Project: Flink
>          Issue Type: Bug
>          Components: REST
>    Affects Versions: 1.5.0, 1.6.0
>            Reporter: Gary Yao
>            Assignee: vinoyang
>            Priority: Blocker
>              Labels: flip6
>             Fix For: 1.5.0, 1.6.0
> This only happens in flip6 mode. The {{CheckpointConfigHandler}} returns the 
> checkpoint mode uppercased. For example:
> {code}
> {"mode":"EXACTLY_ONCE","interval":5000,"timeout":600000,"min_pause":0,"max_concurrent":1,"externalization":{"enabled":false,"delete_on_cancellation":true}}
> {code}
> However, the Web UI expects the value to be lower cased:
> {code}
>   <tr>
>         <td>Checkpointing Mode</td>
>         <td ng-if="checkpointConfig['mode'] == 'exactly_once'">Exactly 
> Once</td>
>         <td ng-if="checkpointConfig['mode'] != 'exactly_once'">At Least 
> Once</td>
>       </tr>
> {code}

This message was sent by Atlassian JIRA

Reply via email to