[ 
https://issues.apache.org/jira/browse/FLINK-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395097#comment-16395097
 ] 

ASF GitHub Bot commented on FLINK-8623:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5449
  
    We cannot fully guard against incorrect network configurations.
    
    Many systems (even HDFS,, AFAIK) simply use `InetAddress.getLocalHost()` 
and rely on correct network configs. Our current strategy already tries to be 
smarter by trying to fond a connecting address, and only fall back to 
`getLocalHost()`.
    
    My feeling is that the strategy is fine (I have not seen connectivity 
issues in a while) and focus on stabilizing the tests.
      - We could reducing the heuristic check to "returns something we can bind 
to"
      - We could add an assumption to the test that `getLocalHost()` is not a 
loopback address and something we can bind to, and then run the tests.
    
    What do you think?


> ConnectionUtilsTest.testReturnLocalHostAddressUsingHeuristics unstable on 
> Travis
> --------------------------------------------------------------------------------
>
>                 Key: FLINK-8623
>                 URL: https://issues.apache.org/jira/browse/FLINK-8623
>             Project: Flink
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Priority: Blocker
>              Labels: test-stability
>             Fix For: 1.5.0, 1.4.3
>
>
> {{ConnectionUtilsTest.testReturnLocalHostAddressUsingHeuristics}} fails on 
> Travis: https://travis-ci.org/apache/flink/jobs/339344442



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to