[
https://issues.apache.org/jira/browse/FLINK-8783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395525#comment-16395525
]
ASF GitHub Bot commented on FLINK-8783:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5684
[FLINK-8783] [tests] Harden SlotPoolRpcTest
## What is the purpose of the change
Wait for releasing of timed out pending slot requests before checking the
number of pending slots requests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink hardenSlotPoolRpcTest
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5684.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5684
----
commit 5f3e1a42e249fd7187d846ae4f851a032f9017f0
Author: Till Rohrmann <trohrmann@...>
Date: 2018-03-12T17:04:38Z
[FLINK-8783] [tests] Harden SlotPoolRpcTest
Wait for releasing of timed out pending slot requests before checking the
number of pending slots requests.
----
> Test instability SlotPoolRpcTest.testExtraSlotsAreKept
> ------------------------------------------------------
>
> Key: FLINK-8783
> URL: https://issues.apache.org/jira/browse/FLINK-8783
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.5.0
> Reporter: Gary Yao
> Assignee: Till Rohrmann
> Priority: Blocker
> Fix For: 1.5.0
>
>
> [https://travis-ci.org/GJL/flink/jobs/346206290]
> {noformat}
> Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.784 sec <<<
> FAILURE! - in org.apache.flink.runtime.jobmaster.slotpool.SlotPoolRpcTest
> testExtraSlotsAreKept(org.apache.flink.runtime.jobmaster.slotpool.SlotPoolRpcTest)
> Time elapsed: 0.016 sec <<< FAILURE!
> java.lang.AssertionError: expected:<0> but was:<1>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at
> org.apache.flink.runtime.jobmaster.slotpool.SlotPoolRpcTest.testExtraSlotsAreKept(SlotPoolRpcTest.java:267)
> {noformat}
> I reproduced this in IntelliJ by configuring 50 consecutive runs of
> {{testExtraSlotsAreKept}}. On my machine the 8th execution fails sporadically.
> commit: eeac022f0538e0979e6ad4eb06a2d1031cbd0146
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
