Github user buptljy commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5638#discussion_r173897783
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
 ---
    @@ -1130,4 +1130,13 @@ object concat_ws {
       }
     }
     
    +object log {
    +  def apply(base: Expression, antilogarithm: Expression): Expression = {
    +    Log(base, antilogarithm)
    +  }
    +  def apply(antilogarithm: Expression): Expression = {
    +    new Log(antilogarithm)
    --- End diff --
    
    1. I've tried it before, but it seems that we can't restructure log(x) and 
ln(x) together because the expression in sql will be reflected directly as an 
instance of case class. Please let me know if you figure it out.
    2. Actually we should use log(base, antilogarithm).


---

Reply via email to