ASF GitHub Bot commented on FLINK-8910:

Github user sihuazhou commented on a diff in the pull request:

    --- Diff: 
    @@ -105,6 +105,8 @@ public T createAndRestore(@Nonnull List<? extends 
Collection<S>> restoreOptions)
    +                   // IMPORTANT: please be careful when modifying the log 
statements because they are used for validation in
    +                   // the automatic end-to-end tests. Those tests might 
fail if they are not aligned with the log message!
                        if (restoreState.isEmpty()) {
                                LOG.debug("Creating {} with empty state.", 
                        } else {
    --- End diff --
    nit: since this log's format is so special, maybe we can introduce a 
`static final Sting LOG_FORMAT = "Creating {} with empty state."` for it, and 
guard it by adding a unit test (feel free to ignore).

> Introduce automated end-to-end test for local recovery (including sticky 
> scheduling)
> ------------------------------------------------------------------------------------
>                 Key: FLINK-8910
>                 URL: https://issues.apache.org/jira/browse/FLINK-8910
>             Project: Flink
>          Issue Type: Test
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.5.0
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>            Priority: Major
>             Fix For: 1.5.0
> We should have an automated end-to-end test that can run nightly to check 
> that sticky allocation and local recovery work as expected.

This message was sent by Atlassian JIRA

Reply via email to