[
https://issues.apache.org/jira/browse/FLINK-8945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398833#comment-16398833
]
ASF GitHub Bot commented on FLINK-8945:
---------------------------------------
GitHub user kailashhd opened a pull request:
https://github.com/apache/flink/pull/5698
[FLINK-8945] [kinesis] Allow customization of KinesisProxy
## What is the purpose of the change
Allow customization of KinesisProxy. In this case we want to override just
the getShardList implementation to use ListShards instead of DescribeStreams.
## Brief change log
- Changed the constructor from private to protected for KinesisProxy
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Also verified with mvn clean verify.
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads
(100MB)*
- *Extended integration test for recovery after master (JobManager)
failure*
- *Added test that validates that TaskInfo is transferred only once
across recoveries*
- *Manually verified the change by running a 4 node cluser with 2
JobManagers and 4 TaskManagers, a stateful streaming program, and killing one
JobManager and two TaskManagers during the execution, verifying that recovery
happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes /
**no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kailashhd/flink KinesisProxy
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5698.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5698
----
commit 3645cdbad2b7f86eded7f0480606fd9f9fe03ec7
Author: Kailash HD <kdayanand@...>
Date: 2018-03-14T16:20:12Z
[FLINK-8945] [kinesis] Allow customization of KinesisProxy
----
> Allow customization of the KinesisProxy
> ---------------------------------------
>
> Key: FLINK-8945
> URL: https://issues.apache.org/jira/browse/FLINK-8945
> Project: Flink
> Issue Type: Improvement
> Reporter: Kailash Hassan Dayanand
> Priority: Minor
>
> Currently the KinesisProxy interface here:
> [https://github.com/apache/flink/blob/310f3de62e52f1f977c217d918cc5aac79b87277/flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java#L125]
> has a private constructor. This restricts extending the class and prevents
> customizations on shard discovery. I am proposing to change this to protected.
> While the creating a new implementation of KinesisProxyInterface is possible,
> I would like to continue to use implementation of getRecords and
> getShardIterator.
> This will be a temporary workaround till FLINK-8944 is submitted.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
