[
https://issues.apache.org/jira/browse/FLINK-8968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400646#comment-16400646
]
ASF GitHub Bot commented on FLINK-8968:
---------------------------------------
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/5705
[FLINK-8968][state]Fix native resource leak caused by ReadOptions
## What is the purpose of the change
This PR fixes
(FLINK-8968)[https://issues.apache.org/jira/browse/FLINK-8968] Pull the
creation of `ReadOptions` out of loop to avoid native resource leak in Full
checkpoint.
## Brief change log
- pull the creation of `ReadOptions` out of loop in
`RocksDBFullSnapshotOperation.writeKVStateMetaData()`
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: ( no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
- The S3 file system connector: (no)
## Documentation
no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sihuazhou/flink fix_readOptions_leak
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5705.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5705
----
commit f1cd2e7f6962e3307e842712c68200362bec61d7
Author: sihuazhou <summerleafs@...>
Date: 2018-03-15T15:57:11Z
Poll the creation of readOptions out of loop to avoid native resource leak.
----
> Fix native resource leak caused by ReadOptions
> -----------------------------------------------
>
> Key: FLINK-8968
> URL: https://issues.apache.org/jira/browse/FLINK-8968
> Project: Flink
> Issue Type: Bug
> Components: State Backends, Checkpointing
> Affects Versions: 1.5.0
> Reporter: Sihua Zhou
> Assignee: Sihua Zhou
> Priority: Major
> Fix For: 1.5.0
>
>
> We should pull the creation of ReadOptions out of the loop in
> {{RocksDBFullSnapshotOperation.writeKVStateMetaData()}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
