[
https://issues.apache.org/jira/browse/FLINK-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14624771#comment-14624771
]
ASF GitHub Bot commented on FLINK-1963:
---------------------------------------
GitHub user pp86 reopened a pull request:
https://github.com/apache/flink/pull/905
[FLINK-1963] Improve distinct() transformation
- add the possibility to use distinct() on Atomic data types
- add the possibility to use distinct("_")/distinct("*") on Atomic data
types
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pp86/flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/905.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #905
----
commit f9a69111c1050d45d14ffb332411af6663482dd5
Author: pietro pinoli <[email protected]>
Date: 2015-07-13T11:32:20Z
[FLINK-1963] Improve distinct() transformation
- add the possibility to use distinct() on Atomic data types
- add the possibility to use distinct("_")/distinct("*") on Atomic data
types
commit da699987852d7481843d8b8b60c976d3d8e61a69
Author: pietro pinoli <[email protected]>
Date: 2015-07-13T11:58:28Z
[FLINK-1963] Improve distinct() transformation …
- add the possibility to use distinct() on Atomic data types
- add the possibility to use distinct("_")/distinct("*") on Atomic data
types
commit 911db2d2efcca227d1fdcf595cb6c5a2cd4e92ce
Author: pietro pinoli <[email protected]>
Date: 2015-07-13T12:01:20Z
Clean code
----
> Improve distinct() transformation
> ---------------------------------
>
> Key: FLINK-1963
> URL: https://issues.apache.org/jira/browse/FLINK-1963
> Project: Flink
> Issue Type: Improvement
> Components: Java API, Scala API
> Affects Versions: 0.9
> Reporter: Fabian Hueske
> Assignee: pietro pinoli
> Priority: Minor
> Labels: starter
> Fix For: 0.9
>
>
> The `distinct()` transformation is a bit limited right now with respect to
> processing atomic key types:
> - `distinct(String ...)` works only for composite data types (POJO, tuple),
> but wildcard expression should also be supported for atomic key types
> - `distinct()` only works for composite types, but should also work for
> atomic key types
> - `distinct(KeySelector)` is the most generic one, but not very handy to use
> - `distinct(int ...)` works only for Tuple data types (which is fine)
> Fixing this should be rather easy.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
