[
https://issues.apache.org/jira/browse/FLINK-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16402055#comment-16402055
]
ASF GitHub Bot commented on FLINK-8915:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5703#discussion_r175126066
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointStatistics.java
---
@@ -273,7 +274,21 @@ public static CheckpointStatistics
generateCheckpointStatistics(AbstractCheckpoi
failedCheckpointStats.getFailureTimestamp(),
failedCheckpointStats.getFailureMessage());
} else {
- throw new IllegalArgumentException("Given checkpoint
stats object of type " + checkpointStats.getClass().getName() + " cannot be
converted.");
+ final PendingCheckpointStats pendingCheckpointStats =
((PendingCheckpointStats) checkpointStats);
--- End diff --
The original `else` block should be kept in case the class hierarchy is
extended.
```
else if (checkpointStats instanceOf PendingCheckpointStats) {
...
} else {
throw new IllegalArgumentException("Given checkpoint stats object of
type " + checkpointStats.getClass().getName() + " cannot be converted.");
}
```
> CheckpointingStatisticsHandler fails to return PendingCheckpointStats
> ----------------------------------------------------------------------
>
> Key: FLINK-8915
> URL: https://issues.apache.org/jira/browse/FLINK-8915
> Project: Flink
> Issue Type: Bug
> Components: REST
> Affects Versions: 1.5.0, 1.6.0
> Reporter: Gary Yao
> Assignee: vinoyang
> Priority: Blocker
> Labels: flip6
> Fix For: 1.5.0
>
>
> {noformat}
> 2018-03-10 21:47:52,487 ERROR
> org.apache.flink.runtime.rest.handler.job.checkpoints.CheckpointingStatisticsHandler
> - Implementation error: Unhandled exception.
> java.lang.IllegalArgumentException: Given checkpoint stats object of type
> org.apache.flink.runtime.checkpoint.PendingCheckpointStats cannot be
> converted.
> at
> org.apache.flink.runtime.rest.messages.checkpoints.CheckpointStatistics.generateCheckpointStatistics(CheckpointStatistics.java:276)
> at
> org.apache.flink.runtime.rest.handler.job.checkpoints.CheckpointingStatisticsHandler.handleRequest(CheckpointingStatisticsHandler.java:146)
> at
> org.apache.flink.runtime.rest.handler.job.checkpoints.CheckpointingStatisticsHandler.handleRequest(CheckpointingStatisticsHandler.java:54)
> at
> org.apache.flink.runtime.rest.handler.job.AbstractExecutionGraphHandler.lambda$handleRequest$0(AbstractExecutionGraphHandler.java:81)
> at
> java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:602)
> at
> java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:577)
> at
> java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:442)
> at akka.dispatch.TaskInvocation.run(AbstractDispatcher.scala:39)
> at
> akka.dispatch.ForkJoinExecutorConfigurator$AkkaForkJoinTask.exec(AbstractDispatcher.scala:415)
> at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)
> at
> scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)
> at
> scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
> at
> scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
