Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5710#discussion_r175402536
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/BufferBuilderAndConsumerTest.java
---
@@ -81,6 +81,24 @@ public void multipleAppends() {
assertContent(bufferConsumer, 0, 1, 2, 3, 42);
}
+ @Test
+ public void multipleFinish() {
+ BufferBuilder bufferBuilder = createBufferBuilder();
+ BufferConsumer bufferConsumer =
bufferBuilder.createBufferConsumer();
+
+ bufferBuilder.appendAndCommit(toByteBuffer(42, 44));
+
+ assertFalse(bufferBuilder.isFinished());
+
+ bufferBuilder.finish();
+ assertTrue(bufferBuilder.isFinished());
+ bufferBuilder.finish();
+ assertTrue(bufferBuilder.isFinished());
+
+ assertContent(bufferConsumer, 42, 44);
--- End diff --
Can you also add a content check like this into `testIsFinished()` because
there is no direct test that a finished buffer and/or consumer actually has the
contents it is supposed to have.
---
