Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5416#discussion_r175483617
  
    --- Diff: 
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java ---
    @@ -206,7 +209,7 @@ public void checkClusterEmpty() throws IOException, 
YarnException {
                        }
                }
     
    -           flinkConfiguration = new 
org.apache.flink.configuration.Configuration();
    +           flinkConfiguration = GlobalConfiguration.loadConfiguration();
    --- End diff --
    
    Can't we read the vanilla configuration in `YarnTestBase#start:474` then 
configure the keytab and the principal and write this `Configuration` out via 
`BootstrapTool#writeConfiguration`? We could then simply set 
`flinkConfiguration` to this `Configuration`. What do you think?


---

Reply via email to