[
https://issues.apache.org/jira/browse/FLINK-9019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405696#comment-16405696
]
ASF GitHub Bot commented on FLINK-9019:
---------------------------------------
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/5723
[FLINK-9019] Unclosed closeableRegistry in
StreamTaskStateInitializerImpl#rawOperatorStateInputs
## What is the purpose of the change
*This pull request fixed a resource(CloseableRegistry) leak.*
## Brief change log
- *create the `ClosableRegistry`'s instance if necessary*
## Verifying this change
This change is already covered by existing tests, such as
*StreamTaskStateInitializerImplTest*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes /
**no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs /
JavaDocs / **not documented**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanghua/flink FLINK-9019
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5723.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5723
----
commit 447c4a56b43d3c0737ad54e4e91846ea54ff7205
Author: yanghua <yanghua1127@...>
Date: 2018-03-20T02:02:21Z
[FLINK-9019] Unclosed closeableRegistry in
StreamTaskStateInitializerImpl#rawOperatorStateInputs
----
> Unclosed closeableRegistry in
> StreamTaskStateInitializerImpl#rawOperatorStateInputs
> -----------------------------------------------------------------------------------
>
> Key: FLINK-9019
> URL: https://issues.apache.org/jira/browse/FLINK-9019
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: vinoyang
> Priority: Minor
>
> {code}
> final CloseableRegistry closeableRegistry = new CloseableRegistry();
> ...
> if (rawOperatorState != null) {
> ...
> }
> }
> return CloseableIterable.empty();
> {code}
> If rawOperatorState is null, closeableRegistry would be left unclosed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
