[GitHub] flink pull request #5699: [FLINK-8942][runtime] Pass heartbeat target Resour...

[zentol]

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5699#discussion_r175730535
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatManagerImpl.java
 ---
    @@ -106,8 +107,8 @@ Executor getExecutor() {
                return heartbeatListener;
        }
     
    -   Collection<HeartbeatManagerImpl.HeartbeatMonitor<O>> 
getHeartbeatTargets() {
    -           return heartbeatTargets.values();
    +   Collection<Map.Entry<ResourceID, HeartbeatMonitor<O>>> 
getHeartbeatTargets() {
    --- End diff --
    
    yes that is a better solution.


---