[ 
https://issues.apache.org/jira/browse/FLINK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406173#comment-16406173
 ] 

ASF GitHub Bot commented on FLINK-8703:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5701#discussion_r175731826
  
    --- Diff: 
flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/SavepointMigrationTestBase.java
 ---
    @@ -194,49 +187,35 @@ protected final void restoreAndExecute(
                        String savepointPath,
                        Tuple2<String, Integer>... expectedAccumulators) throws 
Exception {
     
    -           // Retrieve the job manager
    -           Await.result(cluster.leaderGateway().future(), 
DEADLINE.timeLeft());
    +           ClusterClient<?> client = 
miniClusterResource.getClusterClient();
    +           client.setDetached(true);
    --- End diff --
    
    As a side note which is out of scope for this issue. I think we should 
`deprecate` `ClusterClient#setDetached`. It should not be an attribute of the 
client but more of how you submit a job.


> Migrate tests from LocalFlinkMiniCluster to MiniClusterResource
> ---------------------------------------------------------------
>
>                 Key: FLINK-8703
>                 URL: https://issues.apache.org/jira/browse/FLINK-8703
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Tests
>            Reporter: Aljoscha Krettek
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>             Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to