Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5701#discussion_r175731028
  
    --- Diff: 
flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/SavepointMigrationTestBase.java
 ---
    @@ -87,17 +89,24 @@ protected static String getResourceFilename(String 
filename) {
                return resource.getFile();
        }
     
    -   @Before
    -   public void setup() throws Exception {
    +   private Configuration getConfigurationSafe() {
    --- End diff --
    
    I think we can get rid of this method by moving the `miniClusterResource` 
initialization to the constructor which says that it can throw an `Exception`.


---

Reply via email to