GitHub user sihuazhou opened a pull request: https://github.com/apache/flink/pull/5734
[FLINK-9026][Metrics] Close the TaskManagerMetricGroup when the TaskExecutor is shut down ## What is the purpose of the change We should close the `TaskManagerMetricGroup` when the `TaskExecutor` is shutdown. ## Brief change log - close the `TaskManagerMetricGroup` when the `TaskExecutor` is shutdown. ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**) You can merge this pull request into a Git repository by running: $ git pull https://github.com/sihuazhou/flink FLINK_9026 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5734.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5734 ---- commit 94ecbc87e53b4fff306a864971f164c765122194 Author: sihuazhou <summerleafs@...> Date: 2018-03-21T09:46:31Z close the TaskManagerMetricGroup when the TaskExecutor is shut down ---- ---