[
https://issues.apache.org/jira/browse/FLINK-8946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407886#comment-16407886
]
vinoyang commented on FLINK-8946:
---------------------------------
Yes, for TaskExector we could close it. But for TaskManager, it could be closed
when disconnect from jm and could not be re-init after register to new jm
leader. Thanks. On 2018-03-21 21:03 , Till Rohrmann (JIRA) Wrote: [
https://issues.apache.org/jira/browse/FLINK-8946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407863#comment-16407863
] Till Rohrmann commented on FLINK-8946:
-------------------------------------- I think we should close the
{{TaskManagerMetricGroup}} at some point. E.g. in {{TaskExecutor#postStop}} or
in the caller of {{TaskExecutor}}. > TaskManager stop sending metrics after
JobManager failover >
---------------------------------------------------------- > >
Key: FLINK-8946 > URL:
https://issues.apache.org/jira/browse/FLINK-8946 > Project: Flink >
Issue Type: Bug > Components: Metrics, TaskManager >
Affects Versions: 1.4.2 > Reporter: Truong Duc Kien >
Assignee: vinoyang > Priority: Critical > Fix For: 1.5.0
> > > Running in Yarn-standalone mode, when the Job Manager performs a
failover, all TaskManager that are inherited from the previous JobManager will
not send metrics to the new JobManager and other registered metric reporters. >
> A cursory glance reveal that these line of code might be the cause >
[https://github.com/apache/flink/blob/a3478fdfa0f792104123fefbd9bdf01f5029de51/flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala#L1082-L1086]
> Perhap the TaskManager close its metrics group when disassociating
JobManager, but not creating a new one on fail-over association ? > -- This
message was sent by Atlassian JIRA (v7.6.3#76005)
> TaskManager stop sending metrics after JobManager failover
> ----------------------------------------------------------
>
> Key: FLINK-8946
> URL: https://issues.apache.org/jira/browse/FLINK-8946
> Project: Flink
> Issue Type: Bug
> Components: Metrics, TaskManager
> Affects Versions: 1.4.2
> Reporter: Truong Duc Kien
> Assignee: vinoyang
> Priority: Critical
> Fix For: 1.5.0
>
>
> Running in Yarn-standalone mode, when the Job Manager performs a failover,
> all TaskManager that are inherited from the previous JobManager will not send
> metrics to the new JobManager and other registered metric reporters.
>
> A cursory glance reveal that these line of code might be the cause
> [https://github.com/apache/flink/blob/a3478fdfa0f792104123fefbd9bdf01f5029de51/flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala#L1082-L1086]
> Perhap the TaskManager close its metrics group when disassociating
> JobManager, but not creating a new one on fail-over association ?
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
