[GitHub] flink pull request #5735: [FLINK-9036] [core] Add default values to State De...

[sihuazhou]

Github user sihuazhou commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5735#discussion_r176099489
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/api/common/state/FoldingStateDescriptor.java
 ---
    @@ -55,7 +55,7 @@
         * @param typeClass The type of the values in the state.
         */
        public FoldingStateDescriptor(String name, ACC initialValue, 
FoldFunction<T, ACC> foldFunction, Class<ACC> typeClass) {
    -           super(name, typeClass, initialValue);
    +           super(name, typeClass, DefaultValueFactory.create(typeClass, 
requireNonNull(initialValue)));
                this.foldFunction = requireNonNull(foldFunction);
    --- End diff --
    
    I think use `Preconditions. checkNotNull()` instead of `requireNonNull()` 
here is more consistence with the previous commit: `Make State Descriptors 
consistently use Preconditions…`.


---