[ 
https://issues.apache.org/jira/browse/FLINK-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16409304#comment-16409304
 ] 

Fabian Hueske commented on FLINK-9049:
--------------------------------------

Thanks for the issue [~suez1224].

I think it would be great, if we could do the changes for the yaml file 
(sources -> tables, tableType property) as a separate issue and resolve for 
Flink 1.5. Otherwise, we have to break the config file in the next version.

> Create unified interfaces to configure and instatiate TableSink
> ---------------------------------------------------------------
>
>                 Key: FLINK-9049
>                 URL: https://issues.apache.org/jira/browse/FLINK-9049
>             Project: Flink
>          Issue Type: Task
>          Components: Table API & SQL
>            Reporter: Shuyi Chen
>            Assignee: Shuyi Chen
>            Priority: Major
>
> This is a similar effort to 
> [FLINK-8240|https://issues.apache.org/jira/browse/FLINK-8240], we want to 
> create a unified interface for discovery and instantiation of TableSink, and 
> later support table DDL in flink. The proposed solution would use similar 
> approach in [FLINK-8240|https://issues.apache.org/jira/browse/FLINK-8240], 
> and can re-use most of the implementations already done in 
> [FLINK-8240|https://issues.apache.org/jira/browse/FLINK-8240].
> Below are a few major changes in mind. 
> 1) Add TableSinkFactory/TableSinkFactoryService similar to 
> TableSourceFactory/TableSourceFactoryService
> 2) Add a common property called "tableType" with values (source, sink and 
> both) for both TableSource and TableSink.
> 3) in yaml file, replace "sources" with "tables", and use tableType to 
> identify whether it's source or sink.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to