[ 
https://issues.apache.org/jira/browse/FLINK-9047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16409457#comment-16409457
 ] 

ASF GitHub Bot commented on FLINK-9047:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5739#discussion_r176404156
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/TaskManagerSlot.java
 ---
    @@ -139,6 +139,16 @@ public boolean isMatchingRequirement(ResourceProfile 
required) {
                return resourceProfile.isMatching(required);
        }
     
    +   @Override
    +   public String toString() {
    +           return "TaskManagerSlot{" +
    --- End diff --
    
    `resourceProfile` and `taskManagerConnection` are deliberately not included?


> SlotPool can fail to release slots
> ----------------------------------
>
>                 Key: FLINK-9047
>                 URL: https://issues.apache.org/jira/browse/FLINK-9047
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Blocker
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> The {{SlotPool}} releases idling slots. If the release operation fails (e.g. 
> timeout), then it simply continues using the slot. This is problematic if the 
> owning {{TaskExecutor}} failed before and was unregistered in the meantime 
> from the {{SlotPool}}. As a result, the {{SlotPool}} will reuse the slot and 
> whenever it tries to return because it is idling it will fail again. This, 
> effectively, renders the scheduling of a job impossible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to